Skip to content

Export from data table is broken #33581

Closed
Closed
Export from data table is broken#33581
Assignees
lukeelmers
Labels
Feature:Data TableData table visualization featurePR sentTeam:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//blockerbugFixes for quality problems that affect the customer experienceregressionv7.0.0

Description

@lukasolson
lukasolson
opened on Mar 20, 2019

Not sure when this broke, but when you try to export the raw or formatted values from a data table, you get the following error in the console:

angular.js:14800 TypeError: row.map is not a function
    at eval (agg_table.js:82)
    at Array.map (<anonymous>)
    at controller.self.toCsv (agg_table.js:81)
    at controller.self.exportAsCsv (agg_table.js:61)
    at fn (eval at compile (angular.js:NaN), <anonymous>:4:197)
    at callback (angular.js:27475)
    at ChildScope.$eval (angular.js:18542)
    at ChildScope.$apply (angular.js:18641)
    at HTMLAnchorElement.eval (angular.js:27480)
    at HTMLAnchorElement.dispatch (jquery.js:5183)

Activity

  1. lukasolson
    added
    bugFixes for quality problems that affect the customer experience
    Feature:Data TableData table visualization feature
    Team:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//
    regression
    on Mar 20, 2019

  2. lukasolson commented on Mar 20, 2019

    @lukasolson
    lukasolson
    on Mar 20, 2019
    ContributorAuthor

    Probably related to #19061.

  3. timroes commented on Mar 20, 2019

    @timroes
    timroes
    on Mar 20, 2019
    Contributor

    cc @lukeelmers @ppisljar let's treat this as a blocker for 7.0 so far.

  4. timroes
    added
    blocker
    v7.0.0
    on Mar 20, 2019

  5. ppisljar commented on Mar 21, 2019

    @ppisljar
    ppisljar
    on Mar 21, 2019
    Contributor

    what if we finally remove that from table for 7.0 ?
    (we can export from within inspector)

  6. timroes commented on Mar 26, 2019

    @timroes
    timroes
    on Mar 26, 2019
    Contributor

    I think a lot of users are still liking the export from table directly. I would rather be careful about removing it completely. With the new table redesign I would have liked to make the button optional, but I am not sure if we can simply remove it for 7.0. @AlonaNadler what's your opinion on removing the export buttons below the data table visualization?

  7. AlonaNadler commented on Mar 26, 2019

    @AlonaNadler
    AlonaNadler
    on Mar 26, 2019

    The difficulty with the inspector is that you need to be aware that it exists and that in the inspector there is a way to export the data (the name Inspector is not clearly relating to export to CSV), so only knowledgeable users will find it
    I'm with @timroes, many users are dependent on the direct export table, I agree it is a blocker.

  8. lukeelmers
    self-assigned this
    on Mar 27, 2019
  9. lukasolson
    added
    PR sent
    on Mar 29, 2019
  10. lukeelmers
    closed this as completedin #34131on Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Feature:Data TableData table visualization featurePR sentTeam:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//blockerbugFixes for quality problems that affect the customer experienceregressionv7.0.0

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions