Skip to content

Element done checker fails when expression changes #33898

Description

@w33ble

Kibana version: 6.5+

Describe the bug:

NOTE: This only affects dev.

When an element renders, the ElementShareContainer has a check to make sure handlers.done() is called within 15 seconds of rendering. This is helpful in development since you see that warning if you forget to call that method (every Element should call it when it's done rendering).

However, the code doesn't create that check when the expression changes. You can get the warning to show up, incorrectly, if you start with an error and then get the expression working.

Steps to reproduce:

With you dev console open:

  1. Add a pie element, and change the last function to pies so that it produces an error
  2. Reload the Canvas tab in your browser, so that the initial element render is now the error
  3. Fix the expression so that the last function is pie again
  4. Wait 15 seconds

Screenshots (if relevant):

Screenshot 2019-03-26 15 50 36

Activity

  1. added
    bugFixes for quality problems that affect the customer experience
    Team:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//
    loe:smallSmall Level of Effort
    on Mar 26, 2019
  2. elasticmachine commented on Mar 26, 2019

    @elasticmachine
    Contributor

    Pinging @elastic/kibana-canvas

  3. self-assigned this
    on Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

PR sentTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//bugFixes for quality problems that affect the customer experiencechoreloe:smallSmall Level of Effort

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions