Kibana version:
v6.7, master and likely, everything in between
Browser version:
Chrome Version 73.0.3683.86 (Official Build) (64-bit)
Browser OS version:
OS X 10.14.3
Original install method (e.g. download page, yum, from source, etc.):
From the repo
Describe the bug:
If the last existing page of a workbook is not empty, and is deleted, the app throws and the page has to be reloaded
Steps to reproduce:
- Make an empty workbook
- Add a shape element
- Delete the single existing page
- It throws
Screenshots (if relevant):
Errors in browser console (if relevant):
breaks on var thumb = original.cloneNode(true); in dom_preview.js - original is null (because the query selector didn't find the non-existing DOM node)
Triage notes:
It was discovered while testing #33702 but then found in master too.
Slide sorter rendering (PageManager / DomPreview): dom_preview.js#L22-L25 expects that upon a Redux state change such as a page addition, the DOM with the original page had been updated by the time we get to this querySelector. The large page is rendered in another path in the component tree (WorkpadPage) - what is it that ensures that the WorkpadPage component mounts earlier in the DOM than the corresponding DomPreview component? One of the last two (known) open issues in #33702 is a regression, apparently DomPreview tries to clone a DOM element (page) that hasn't yet been inserted in the DOM
Labels indicate detection (v6.7 and current master) and anything in between.
Kibana version:
v6.7,masterand likely, everything in betweenBrowser version:
Chrome Version 73.0.3683.86 (Official Build) (64-bit)
Browser OS version:
OS X 10.14.3
Original install method (e.g. download page, yum, from source, etc.):
From the repo
Describe the bug:
If the last existing page of a workbook is not empty, and is deleted, the app throws and the page has to be reloaded
Steps to reproduce:
Screenshots (if relevant):
Errors in browser console (if relevant):
breaks on
var thumb = original.cloneNode(true);indom_preview.js-originalis null (because the query selector didn't find the non-existing DOM node)Triage notes:
It was discovered while testing #33702 but then found in
mastertoo.Slide sorter rendering (
PageManager/DomPreview): dom_preview.js#L22-L25 expects that upon a Redux state change such as a page addition, the DOM with the original page had been updated by the time we get to thisquerySelector. The large page is rendered in another path in the component tree (WorkpadPage) - what is it that ensures that theWorkpadPagecomponent mounts earlier in the DOM than the correspondingDomPreviewcomponent? One of the last two (known) open issues in #33702 is a regression, apparentlyDomPreviewtries to clone a DOM element (page) that hasn't yet been inserted in the DOMLabels indicate detection (
v6.7and currentmaster) and anything in between.