Skip to content

Conversation

@fin09pcap
Copy link
Member

  • Update .goreleaser.yaml for version 2 configuration.

Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
@fin09pcap fin09pcap self-assigned this Apr 29, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the goreleaser configuration file to version 2. The changes include:

  • Adding a YAML schema comment and updating the version.
  • Modifying the gomod proxy setting and archives configuration.
  • Changing the snapshot and changelog configuration to match the new version 2 schema.
Comments suppressed due to low confidence (2)

.goreleaser.yaml:11

  • Ensure that changing the gomod proxy setting to 'false' complies with the intended behavior for module resolution in version 2. If this change is deliberate, consider adding documentation to clarify the reasoning.
proxy: false

.goreleaser.yaml:63

  • Verify that replacing 'skip: true' with 'disable: true' in the changelog section reflects the correct behavior in version 2. Adjust documentation if the new field has different semantics.
disable: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the Nancy scanner isn't too happy, but I don't see how that's caused specifically by your changes. I'll approve in case you need to force the merge in order to move on with things.

@fin09pcap fin09pcap merged commit b00806b into elastic:main Apr 29, 2025
13 of 14 checks passed
@fin09pcap fin09pcap deleted the build/releaser_configuration_update branch April 29, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants