Conversation
Collaborator
Author
|
ignore CI as it's pending on another PR |
QUARK_VERSION should be shared by libquark, quark-btf, quark-mon and also elastic/go-quark. A release has the form "MAJOR.MINOR", we break ABI *freely*, so a MINOR can break ABI. MAJOR denotes a major milestone, or some cool stuff that was added. Quark is not meant to be distributed as a shared object, therefore it makes no sense for us to be careful with ABI breakages, users should be building quark together with their application. We should document them in a CHANGES file for every release. The suffix "a" is added to the version we are working on, so when we're about to release: remove the suffix; release; bump with suffix.
nfritts
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QUARK_VERSION should be shared by libquark, quark-btf, quark-mon and also elastic/go-quark.
A release has the form "MAJOR.MINOR", we break ABI freely, so a MINOR can break ABI. MAJOR denotes a major milestone, or some cool stuff that was added.
Quark is not meant to be distributed as a shared object, therefore it makes no sense for us to be careful with ABI breakages, users should be building quark together with their application. We should document them in a CHANGES file for every release.
The suffix "a" is added to the version we are working on, so when we're about to release: remove the suffix; release; bump with suffix.
tip for review: ignore the html part as it's autogenerated.
cc @mjwolf