Fix a race in ktest-all and improve output#105
Merged
Merged
Conversation
Turns out I broke it on last commit when there is more than one kernel to test, both processes were attempting to read from stdin, so revert that and fix it differently. While here, improve some idioms and collect errored out commands to be printed in the end, should make people less angry in the future when stuff just "fails".
3668250 to
ca07604
Compare
Merged
nicholasberlin
approved these changes
Nov 25, 2024
Contributor
nicholasberlin
left a comment
There was a problem hiding this comment.
After forcing krun.sh to fail, output looked good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out I broke it on last commit when there is more than one kernel to test, both processes were attempting to read from stdin, so revert that and fix it differently.
While here, improve some idioms and collect errored out commands to be printed in the end, should make people less angry in the future when stuff just "fails".