Conversation
Collaborator
haesbaert
commented
Jan 14, 2025
- Bump retries on insert from 10 to 1000 before giving up.
- Put a timeout on drain_for_pid(), I used to manually test the changing paths, and it's good to have anyway.
- Check if clock_gettime() works in quark_queue_open(), maybe it gets EPERM due to seccomp and whatnot, sanitize return of now64(), program still survives. I just don't want to check now64() errors while they're impossible.
- Bump retries on insert from 10 to 1000 before giving up. - Put a timeout on drain_for_pid(), I used to manually test the changing paths, and it's good to have anyway. - Check if clock_gettime() works in quark_queue_open(), maybe it gets EPERM due to seccomp and whatnot, sanitize return of now64(), program still survives. I just don't want to check now64() errors while they're impossible.
nicholasberlin
approved these changes
Jan 14, 2025
| raw_event_insert(qq, raw); | ||
| if (raw_event_insert(qq, raw) == -1) { | ||
| raw_event_free(raw); | ||
| raw = NULL; |
Contributor
There was a problem hiding this comment.
good catch setting this to NULL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.