Skip to content

Load tty_write probe for BYPASS#186

Merged
haesbaert merged 3 commits into
mainfrom
tty_write_for_bypass
Jun 5, 2025
Merged

Load tty_write probe for BYPASS#186
haesbaert merged 3 commits into
mainfrom
tty_write_for_bypass

Conversation

@nicholasberlin
Copy link
Copy Markdown
Contributor

No description provided.

@nicholasberlin nicholasberlin requested a review from a team as a code owner June 5, 2025 01:09
@haesbaert
Copy link
Copy Markdown
Collaborator

haesbaert commented Jun 5, 2025

I'd rather have QQ_TTY that only works on bypass(same dance of QQ_MEMFD), I say this because in the future I think tty events are also interesting outside of bypass. Currently setsid is there because my plan is to make it default outside of bypass as well (basically all process things are default).
What do you think? I'll push a change, here, and if you don't like it I can remove it.

@haesbaert
Copy link
Copy Markdown
Collaborator

Pushed, also added a tiny test that at least tells is if the tty probe loads

@nicholasberlin
Copy link
Copy Markdown
Contributor Author

Make sense to me, I realized we don't always want to load those probes for BYPASS.

Thanks! LGTM

@haesbaert haesbaert merged commit 3f9698b into main Jun 5, 2025
2 checks passed
@nicholasberlin nicholasberlin deleted the tty_write_for_bypass branch October 28, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants