Add an API for starting upcoming quark-kube-talker#214
Merged
Conversation
This is more preparatory work for kubernetes support. We have to be flexible, this means being able to run on an environment without multithreading, in an environment with multithreading, and in some gc runtime like golang. The object is to have "something" that feeds a file descriptor with kubernetes events, this "something" is the upcoming quark-kube-talker. We tell quark that kubernetes is active by setting up a quark-kube-talker (or whatever), and feeing quark_queue_open with the pipe to read from. For now, management of the filedescriptor is done by the caller, so it must start quark-kube-talker, get the fd, and close on its own.
nfritts
approved these changes
Aug 11, 2025
| qwarnx("not closing child descriptors"); | ||
| } | ||
|
|
||
| snprintf(pidbuf, sizeof(pidbuf), "%d", pipefd[1]); |
Contributor
There was a problem hiding this comment.
why named pidbuf? it's filled with a file descriptor, right?
Collaborator
Author
There was a problem hiding this comment.
whoooooooooooooops, it used to be a pid, and the pipe was on another buffer, I changed and renamed the wrong one, I'll fix it, I also realized, that I had my tabs disabled in emacs and the whole function is not using tabs. :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more preparatory work for kubernetes support.
We have to be flexible, this means being able to run on an environment without multithreading, in an environment with multithreading, and in some gc runtime like golang.
The object is to have "something" that feeds a file descriptor with kubernetes events, this "something" is the upcoming quark-kube-talker.
We tell quark that kubernetes is active by setting up a quark-kube-talker (or whatever), and feeing quark_queue_open with the pipe to read from. For now, management of the filedescriptor is done by the caller, so it must start quark-kube-talker, get the fd, and close on its own.