Add support for more container engines#222
Merged
Merged
Conversation
|
💚 CLA has been signed |
1e37f10 to
7401c5d
Compare
haesbaert
reviewed
Sep 8, 2025
Collaborator
haesbaert
left a comment
There was a problem hiding this comment.
Thanks for testing it and adding those!
I think we can cut the case and the code would get much simpler, see the comments.
Collaborator
|
Heya so I've added the stuff we talked about, see if you're ok with it, also for some reason your CLA is acting up? |
32257d4 to
e4d9932
Compare
Contributor
Author
fixd |
stanek-michal
commented
Sep 11, 2025
Contributor
Author
stanek-michal
left a comment
There was a problem hiding this comment.
realized I can't approve a PR I started, we need volunteers
Collaborator
fear not, now I realized I can |
e4d9932 to
06f6edd
Compare
haesbaert
approved these changes
Sep 12, 2025
06f6edd to
2eb3fe9
Compare
Should be plucky, not oracular.
2eb3fe9 to
bd74d70
Compare
Contributor
nicholasberlin
left a comment
There was a problem hiding this comment.
Looks good, one question
With this change, quark k8s awareness works on non-docker runtimes. Spotted when running quark on GKE which uses containerd like most modern k8s deployments. We only support the systemd scheme, meaning foo-<id>.scope. Co-authored-by: Christiano Haesbaert <haesbaert@elastic.co>
bd74d70 to
34ad9e3
Compare
nicholasberlin
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, quark k8s awareness works on non-docker runtimes.
Spotted when running quark on GKE which uses containerd like most modern k8s deployments. Confirmed working on GKE cluster.
Fixed a bug along the way:
terminated = GET(container_json, "terminated");to
terminated = GET(state, "terminated");