Conversation
* Fix spinning cursor, the unit is in usec, not msec, initially it should have
been 25ms, but that's also too fast, so bump it to 100ms.
* Don't hammer isatty(3) by caching fancy_tty once.
* Don't try to spin on valgrind.
* Make it so that test{} represents a single test, it doesn't represent both a
bpf and kprobe test anymore, so now they're two test{} structures. This
also simplifies the excluding logic.
* Make it so that T_ now passes NULL as quark_queue_attr, for tests that have
nothing to do with a queue, like t_hanson.
* Implement a cool progress bar, successfull cases print a green #, while failed
ones print a red #, it's xmas, so have some joy.
nicholasberlin
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
been 25ms, but that's also too fast, so bump it to 100ms.
bpf and kprobe test anymore, so now they're two test{} structures. This
also simplifies the excluding logic.
nothing to do with a queue, like t_hanson.
ones print a red #, it's xmas, so have some joy.