Conversation
nicholasberlin
approved these changes
Apr 27, 2026
Cut the _PROCESS_ from QUARK_RF_*, it's just bloat and PROCESS is too long, it makes lines expand too much. Also rename filename to exe, this is a breaking change. Filename was inherited from the kprobe backend, where the kprobe itself calls it filename, I can't stand it. EXE is more descriptive.
ricardoamaro
approved these changes
Apr 27, 2026
ricardoamaro
left a comment
There was a problem hiding this comment.
LGTM! The renames look clean and applied consistently across all 8 files.
Collaborator
Author
|
Issue #315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cut the PROCESS from QUARK_RF_*, it's just bloat and PROCESS is too long, it
makes lines expand too much.
Also rename filename to exe, this is a breaking change.
Filename was inherited from the kprobe backend, where the kprobe itself calls it
filename, I can't stand it. EXE is more descriptive.