Skip to content

fix: the callback of beginFrameSubscription should pass NativeImage instead of Buffer #19647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codebytere merged 1 commit into from
Aug 6, 2019
Merged

fix: the callback of beginFrameSubscription should pass NativeImage instead of Buffer #19647

codebytere merged 1 commit into from
Aug 6, 2019

Conversation

@zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Aug 6, 2019

Backport of #17548 to 5-0-x.

notes: Fix the callback of beginFrameSubscription passing Buffer instead of NativeImage.

@zcbenz
fix: the callback of beginFrameSubscription should pass NativeImage i…
6f1a7dd 
…nstead of Buffer (#17548)

* Revert "revert: frame subscriber deprecation and re-enable tests"

This reverts commit f643ce4.

* fix: make sure SkBitmap's pixels are copied
@zcbenz zcbenz requested a review from codebytere August 6, 2019 12:37
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 6, 2019
@trop trop bot mentioned this pull request Aug 6, 2019
Merged
5 tasks
@codebytere codebytere added 5-0-x backport This is a backport PR labels Aug 6, 2019
@codebytere codebytere changed the title fix: the callback of beginFrameSubscription should pass NativeImage instead of Buffer (5-0-x) fix: the callback of beginFrameSubscription should pass NativeImage instead of Buffer Aug 6, 2019
@codebytere codebytere removed the new-pr 🌱 PR opened recently label Aug 6, 2019
@codebytere codebytere merged commit 5a8bdb2 into 5-0-x Aug 6, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 6, 2019

Release Notes Persisted

Fix the callback of beginFrameSubscription passing Buffer instead of NativeImage.

@codebytere codebytere deleted the fix-frame-subscriber-5 branch August 6, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

5-0-x backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcbenz @codebytere