Skip to content

fix: don't package mojom{,-lite}.js files in dist.zip #19192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 1 commit into from
Jul 11, 2019
Merged

fix: don't package mojom{,-lite}.js files in dist.zip #19192

zcbenz merged 1 commit into from
Jul 11, 2019

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Jul 10, 2019

Backport of #18444

See that PR for details.

Notes: Removed inadvertently included mojom.js files from distribution bundle.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 10, 2019
@trop trop bot mentioned this pull request Jul 10, 2019
Merged
6 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Jul 10, 2019
@miniak miniak requested review from jkleinsc and nornagon July 10, 2019 11:17
@miniak miniak mentioned this pull request Jul 10, 2019
Merged
3 tasks
@miniak miniak added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Jul 10, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 10, 2019
@miniak miniak requested a review from alexeykuzmin July 10, 2019 12:19
@miniak miniak removed the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Jul 11, 2019
@zcbenz zcbenz merged commit b8f3325 into 5-0-x Jul 11, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 11, 2019

Release Notes Persisted

Removed inadvertently included mojom.js files from distribution bundle.

@zcbenz zcbenz deleted the trop/5-0-x-bp-fix-don-t-package-mojom-lite-js-files-in-dist-zip-1562757316453 branch July 11, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@nornagon nornagon Awaiting requested review from nornagon

2 more reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

5-0-x backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexeykuzmin @zcbenz @miniak @nornagon