Skip to content

fix: handle WM_GETMINMAXINFO instead of letting chromium do it #20001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ckerr merged 1 commit into from
Aug 28, 2019
Merged

fix: handle WM_GETMINMAXINFO instead of letting chromium do it #20001

ckerr merged 1 commit into from
Aug 28, 2019

Conversation

@brenca
Copy link
Contributor

@brenca brenca commented Aug 28, 2019

Backport of #19928

See that PR for details.

Notes: Fixed a bug where windows would sometimes shrink to 0 size after being restored on Windows.

@brenca
fix: handle WM_GETMINMAXINFO instead of letting chromium do it (#19928)
9be0dc9 
* fix: remove WM_GETMINMAXINFO workaround since it's no longer needed

* fix: handle WM_GETMINMAXINFO ourselves

* fix: remove part of the chromium WM_GETMINMAXINFO handler
@brenca brenca added backport This is a backport PR 6-0-x labels Aug 28, 2019
@trop trop bot mentioned this pull request Aug 28, 2019
Merged
4 tasks
@ckerr ckerr merged commit fb82bfa into 6-0-x Aug 28, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 28, 2019

Release Notes Persisted

Fixed a bug where windows would sometimes shrink to 0 size after being restored on Windows.

@ckerr ckerr deleted the brenca/restore-after-minimize-6-0-x branch August 28, 2019 14:32
@whyboris
Copy link

whyboris commented Aug 30, 2019

Thank you @brenca 🙇 Confirming that this bugfix, just released with Electron 6.0.6 closes my issue: #19816 🙇

@whyboris whyboris mentioned this pull request Aug 30, 2019
Closed
16 tasks
@ToadKing ToadKing mentioned this pull request Oct 10, 2019
Closed
3 tasks
deepak1556 added a commit that referenced this pull request Nov 15, 2019
@deepak1556
Revert "fix: handle WM_GETMINMAXINFO instead of letting chromium do it (
309bf47 
#19928) (#20001)"

This reverts commit fb82bfa.
codebytere pushed a commit that referenced this pull request Nov 18, 2019
@deepak1556 @codebytere
fix: incorrect size of windows on differently scaled monitors (#21137)
bd96771 
* Revert "fix: handle WM_GETMINMAXINFO instead of letting chromium do it (#19928) (#20001)"

This reverts commit fb82bfa.

* fix: don't reset the width and height when correcting window placement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

Assignees

No one assigned

Labels

6-0-x backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brenca @whyboris @ckerr