Skip to content

fix: implement 'login' event for net.ClientRequest #21135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 10 commits into from
Nov 21, 2019
Merged

fix: implement 'login' event for net.ClientRequest #21135

jkleinsc merged 10 commits into from
Nov 21, 2019

Conversation

@nornagon
Copy link
Contributor

@nornagon nornagon commented Nov 14, 2019

Backport of #21096. See that change for details.

Notes: Fixed the 'login' event not being emitted when HTTP Basic auth was requested during a net.request.

@nornagon nornagon requested a review from a team as a code owner November 14, 2019 23:44
@trop trop bot mentioned this pull request Nov 14, 2019
Merged
6 tasks
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 14, 2019
@trop trop bot added 7-1-x backport This is a backport PR labels Nov 14, 2019
@nornagon
Copy link
Contributor Author

nornagon commented Nov 14, 2019

NB. this also includes #21097, to reduce conflicts. Once that backport lands, I'll rebase this.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 14, 2019
@nornagon nornagon mentioned this pull request Nov 15, 2019
Merged
@nornagon nornagon force-pushed the backport/7-1-x/net-login branch from 594072b to ece9a24 Compare November 18, 2019 18:43
@jkleinsc jkleinsc merged commit de428e9 into 7-1-x Nov 21, 2019
@jkleinsc jkleinsc deleted the backport/7-1-x/net-login branch November 21, 2019 17:06
@release-clerk
Copy link

release-clerk bot commented Nov 21, 2019

Release Notes Persisted

Fixed the 'login' event not being emitted when HTTP Basic auth was requested during a net.request.

@nornagon nornagon mentioned this pull request Nov 26, 2019
Closed
3 tasks
@byjrack byjrack mentioned this pull request Jun 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees

No one assigned

Labels

7-1-x backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nornagon @jkleinsc