Skip to content

fix: nullptr check when closing windows #23023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codebytere merged 3 commits into from
Apr 8, 2020
Merged

fix: nullptr check when closing windows #23023

codebytere merged 3 commits into from
Apr 8, 2020

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Apr 8, 2020

Backport of #22948

See that PR for details.

Notes: Fixed an occasional crash when closing all BrowserWindows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 8, 2020
@trop trop bot requested a review from codebytere April 8, 2020 03:41
@trop trop bot mentioned this pull request Apr 8, 2020
Merged
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Apr 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 8, 2020
@codebytere codebytere merged commit ab41460 into 9-x-y Apr 8, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 8, 2020

Release Notes Persisted

Fixed an occasional crash when closing all BrowserWindows.

@codebytere codebytere deleted the trop/9-x-y-bp-fix-nullptr-check-when-closing-windows-1586317303622 branch April 8, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

9-x-y backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codebytere