fix: honor pageRanges when printing #25600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
zcbenz
suggested changes
Oct 6, 2020
Contributor
zcbenz
left a comment
There was a problem hiding this comment.
There are typescript errors:
ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts
[tsl] ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts(280,27)
TS2339: Property 'from' does not exist on type 'PageRanges[]'.
ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts
[tsl] ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts(285,27)
TS2339: Property 'to' does not exist on type 'PageRanges[]'.
ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts
[tsl] ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts(292,24)
TS2339: Property 'from' does not exist on type 'PageRanges[]'.
ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts
[tsl] ERROR in /Users/distiller/project/src/electron/lib/browser/api/web-contents.ts(293,22)
TS2339: Property 'to' does not exist on type 'PageRanges[]'.
Member
|
@codebytere is this PR still live? |
Member
Author
|
@ckerr i need to figure out the TS stuff but yes! |
jkleinsc
requested changes
Nov 3, 2020
Member
jkleinsc
left a comment
There was a problem hiding this comment.
Looks like a doc change was missed - other than that LGTM
ad87d5d to
9d1a3dd
Compare
46967357
approved these changes
Nov 9, 2020
9d1a3dd to
804cbe8
Compare
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
804cbe8 to
fc9c681
Compare
zcbenz
approved these changes
Nov 10, 2020
jkleinsc
approved these changes
Nov 10, 2020
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25064.
See that PR for more details.
Notes: Fixed an issue where pageRanges was not properly honored when printing.