Skip to content

fix: pass require.resolve paths option to wrapped method #25944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 1 commit into from
Oct 15, 2020
Merged

fix: pass require.resolve paths option to wrapped method #25944

zcbenz merged 1 commit into from
Oct 15, 2020

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Oct 14, 2020

Backport of #25891

See that PR for details.

Notes: Fixed bug that meant require.resolve paths option was ignored

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 14, 2020
@trop trop bot mentioned this pull request Oct 14, 2020
Merged
4 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 14, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 14, 2020
@zcbenz zcbenz merged commit ac917b5 into 10-x-y Oct 15, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 15, 2020

Release Notes Persisted

Fixed bug that meant require.resolve paths option was ignored

@zcbenz zcbenz deleted the trop/10-x-y-bp-fix-pass-require-resolve-paths-option-to-wrapped-method-1602695643384 branch October 15, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10-x-y backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcbenz @ascorbic