Skip to content

feat: add support for UNNotificationResponse in app 'ready' event #25950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexeykuzmin merged 1 commit into from
Oct 28, 2020
Merged

feat: add support for UNNotificationResponse in app 'ready' event #25950

alexeykuzmin merged 1 commit into from
Oct 28, 2020

Conversation

@miniak
Copy link
Contributor

@miniak miniak commented Oct 14, 2020 •
edited
Loading

Description of Change

Fill launchInfo of app event ready with information from UNNotificationResponse when the app is launched via a notification presented by UNUserNotificationCenter (in a native node module).
Motivated by #18286. Follow-up to #25702.

Checklist

Release Notes

Notes: The launchInfo of app event ready is now populated with information from UNNotificationResponse when the app is launched via a notification presented by UNUserNotificationCenter (in a native node module).

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 14, 2020
@miniak miniak self-assigned this Oct 14, 2020
@miniak miniak marked this pull request as draft October 14, 2020 20:35
@miniak miniak force-pushed the miniak/UNNotificationResponse branch from 7586603 to 2cd8cc0 Compare October 14, 2020 20:44
@miniak miniak marked this pull request as ready for review October 14, 2020 20:50
MarshallOfSound
MarshallOfSound requested changes Oct 14, 2020
View reviewed changes
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 15, 2020
@miniak miniak force-pushed the miniak/UNNotificationResponse branch 2 times, most recently from 347515a to e30fc02 Compare October 23, 2020 00:24
@miniak miniak marked this pull request as draft October 23, 2020 00:35
@miniak miniak added the wip ⚒ label Oct 23, 2020
@miniak miniak changed the title feat: add support for UNNotificationResponse at NSApplicationLaunchUserNotificationKey feat: add support for UNNotificationResponse in app 'ready' event Oct 23, 2020
@miniak miniak force-pushed the miniak/UNNotificationResponse branch 2 times, most recently from b200a43 to 286ebdf Compare October 23, 2020 21:53
@miniak miniak force-pushed the miniak/UNNotificationResponse branch from 286ebdf to 335e940 Compare October 23, 2020 22:02
@miniak miniak force-pushed the miniak/UNNotificationResponse branch 2 times, most recently from f5568cc to 7ba37bb Compare October 26, 2020 19:12
@miniak miniak removed the wip ⚒ label Oct 26, 2020
@miniak miniak force-pushed the miniak/UNNotificationResponse branch from 7ba37bb to 9b07511 Compare October 26, 2020 21:47
@miniak miniak marked this pull request as ready for review October 26, 2020 21:57
@alexeykuzmin alexeykuzmin merged commit d2727f5 into master Oct 28, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 28, 2020

Release Notes Persisted

The launchInfo of app event ready is now populated with information from UNNotificationResponse when the app is launched via a notification presented by UNUserNotificationCenter (in a native node module).

@alexeykuzmin alexeykuzmin deleted the miniak/UNNotificationResponse branch October 28, 2020 01:25
@joanx joanx mentioned this pull request Apr 1, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@codebytere codebytere Awaiting requested review from codebytere

+1 more reviewer

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miniak miniak

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miniak @alexeykuzmin @deepak1556 @MarshallOfSound