fix: correct null pointer checks in autoresizing browser views #25951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Oct 14, 2020
Member
codebytere
left a comment
There was a problem hiding this comment.
i don't think there's any real way to test this - so this looks good to me :)
Member
Author
Ok, great! |
4 tasks
Contributor
|
@mlaurencin has manually backported this PR to "11-x-y", please check out #25956 |
zcbenz
approved these changes
Oct 15, 2020
MarshallOfSound
approved these changes
Oct 15, 2020
|
Release Notes Persisted
|
This was referenced Oct 19, 2020
Contributor
|
I have automatically backported this PR to "10-x-y", please check out #26033 |
Contributor
|
I have automatically backported this PR to "9-x-y", please check out #26034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #25728
This PR is restoring the ability for browser views to auto-resize. Previously when a window was resized, the browser view would remain the same size. Now the browser view resizes automatically with the window.
cc @codebytere
Checklist
npm testpassesRelease Notes
Notes: Browser views will properly resize within windows.