Skip to content

fix: bind fake mojo service for badging #25370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 2 commits into from
Sep 10, 2020
Merged

fix: bind fake mojo service for badging #25370

zcbenz merged 2 commits into from
Sep 10, 2020

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Sep 8, 2020

Backport of #25294

See that PR for details.

Notes: Fixed a crash in the renderer process when invoking the Badging API.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 8, 2020
@trop trop bot requested a review from codebytere September 8, 2020 15:14
@trop trop bot mentioned this pull request Sep 8, 2020
Merged
4 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Sep 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 8, 2020
@zcbenz zcbenz merged commit 119cd24 into 11-x-y Sep 10, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 10, 2020

Release Notes Persisted

Fixed a crash in the renderer process when invoking the Badging API.

@zcbenz zcbenz deleted the trop/11-x-y-bp-fix-bind-fake-mojo-service-for-badging-1599578055799 branch September 10, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere Awaiting requested review from codebytere

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

11-x-y backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcbenz @codebytere