Skip to content

fix: getLoginItemSettings() on windows #26538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 4 commits into from
Nov 18, 2020
Merged

fix: getLoginItemSettings() on windows #26538

zcbenz merged 4 commits into from
Nov 18, 2020

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Nov 17, 2020

Backport of #26515

See that PR for details.

Notes:

  • Fixed detection of launch on login items
  • Fixed detection of enabled state set by TaskManager

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 17, 2020
@trop trop bot mentioned this pull request Nov 17, 2020
Merged
5 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Nov 17, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 17, 2020
@zcbenz
Copy link
Contributor

zcbenz commented Nov 18, 2020

The failing test is not related to this PR:

not ok 1064 session.serviceWorkers getFromVersionID() should report the correct script url and scope
41825  Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\projects\src\electron\spec-main\api-service-workers-spec.ts)
41826      at listOnTimeout (internal/timers.js:549:17)
41827      at processTimers (internal/timers.js:492:7)
41828(node:12404) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
41829

@zcbenz zcbenz merged commit b14c57e into 11-x-y Nov 18, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 18, 2020

Release Notes Persisted

  • Fixed detection of launch on login items
  • Fixed detection of enabled state set by TaskManager

@zcbenz zcbenz deleted the trop/11-x-y-bp-fix-getloginitemsettings-on-windows-1605644002248 branch November 18, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

11-x-y backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcbenz @bitdisaster