Skip to content

fix: set app locale after user's script is loaded #26242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codebytere merged 1 commit into from
Oct 29, 2020
Merged

fix: set app locale after user's script is loaded #26242

codebytere merged 1 commit into from
Oct 29, 2020

Conversation

@zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Oct 29, 2020

Backport of #26185

See that PR for details.

Notes: Fix calling app.commandLine.appendSwitch('lang') not changing app's locale.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 29, 2020
@trop trop bot mentioned this pull request Oct 29, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Oct 29, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 29, 2020
@codebytere codebytere merged commit f1ffcb5 into 9-x-y Oct 29, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 29, 2020

Release Notes Persisted

Fix calling app.commandLine.appendSwitch('lang') not changing app's locale.

@codebytere codebytere deleted the fix-app-locale-9 branch October 29, 2020 03:23
@lights0123 lights0123 mentioned this pull request Nov 11, 2020
Closed
3 tasks
@ckerr ckerr mentioned this pull request Nov 20, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

9-x-y backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcbenz @codebytere