Skip to content

fix: window.open not accepting size values with "px" at the end #26333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarshallOfSound merged 2 commits into from
Nov 4, 2020
Merged

fix: window.open not accepting size values with "px" at the end #26333

MarshallOfSound merged 2 commits into from
Nov 4, 2020

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Nov 4, 2020

Backport of #26104

See that PR for details.

notes: Fix window.open not accepting size values with "px" at the end.

Code-Blooded-Human and others added 2 commits November 4, 2020 01:34
@Code-Blooded-Human @electron-bot
fix: use parseInt to parse sizes
f67d641
@MarshallOfSound @electron-bot
fix: pass radix to parseInt
33a9d0d 
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 4, 2020
@trop trop bot mentioned this pull request Nov 4, 2020
Merged
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Nov 4, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 4, 2020
@MarshallOfSound MarshallOfSound merged commit fee2655 into 10-x-y Nov 4, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 4, 2020

Release Notes Persisted

Fix window.open not accepting size values with "px" at the end.

@trop trop bot deleted the trop/10-x-y-bp-fix-window-open-not-accepting-size-values-with-px-at-the-end-1604453693337 branch November 4, 2020 19:00
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

10-x-y backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere @MarshallOfSound @Code-Blooded-Human