fix: make draggable regions work when devtools is opened on macOS #26361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
Nov 9, 2020
codebytere
approved these changes
Nov 9, 2020
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "9-x-y" cleanly; |
This was referenced Nov 9, 2020
Contributor
|
I have automatically backported this PR to "10-x-y", please check out #26394 |
Contributor
|
I have automatically backported this PR to "11-x-y", please check out #26395 |
Contributor
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #3647.
On macOS the draggable regions would stop working when devtools is opened, because the docked devtools is implemented by placing the devtools view under the main WebContents, and the devtools view itself is not draggable.
This PR makes the devtools view itself draggable to make the draggable regions work, and then put a view above the devtools area to exclude it from dragging.
The UI structure looks like this:
Checklist
npm testpassesRelease Notes
Notes: Fix draggable regions stops working when devtools is opened on macOS