fix: enable system maximization for frameless windows except if transparent #28622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parent (#28207) * fix: move widget maximization check * fix linting error * change workaround to only effect transparent windows * disable menu maximize and restore for transparent windows * disable double clicking title bar max/unmax for transparent windows * add docs change and address review
4 tasks
jkleinsc
approved these changes
Apr 12, 2021
zcbenz
approved these changes
Apr 13, 2021
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "11-x-y", please check out #28635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backport of #28207
Checklist
npm testpassesRelease Notes
Notes: Transparent windows cannot be maximized using the Windows system menu or by double clicking the title bar.