Skip to content

fix: handle async nature of [NSWindow -toggleFullScreen] #28763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 1 commit into from
Apr 22, 2021
Merged

fix: handle async nature of [NSWindow -toggleFullScreen] #28763

jkleinsc merged 1 commit into from
Apr 22, 2021

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Apr 21, 2021

Backport of #25470.

See that PR for details.

Notes: Fixed an issue where multiple calls to window.setFullScreen could cause problems.

@codebytere codebytere requested a review from a team April 21, 2021 16:27
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 21, 2021
@trop trop bot mentioned this pull request Apr 21, 2021
Merged
4 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 21, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 21, 2021
@jkleinsc jkleinsc merged commit 232392f into 13-x-y Apr 22, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 22, 2021

Release Notes Persisted

Fixed an issue where multiple calls to window.setFullScreen could cause problems.

@jkleinsc jkleinsc deleted the async-window-13 branch April 26, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees

No one assigned

Labels

13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codebytere @jkleinsc