fix: allow Node.js to manage microtasks queue #28973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `uv_run()` resulted in invocation of JS functions the microtask queue checkpoint in Node's CallbackScope was a no-op because the expected microtask queue policy was `kExplicit` and Electron ran under `kScoped` policy. This change switches policy to `kExplicit` right before `uv_run()` and reverts it back to original value after `uv_run()` completes to provide better compatibility with Node.
5 tasks
deepak1556
approved these changes
May 4, 2021
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #28957
See that PR for details.
Notes: Allow Node.js to manage microtasks queue by using explicit microtasks policy before calling
uv_run()