Skip to content

fix: make sure service worker scheme is registered with allowServiceWorkers #28354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 5 commits into from
Mar 24, 2021
Merged

fix: make sure service worker scheme is registered with allowServiceWorkers #28354

zcbenz merged 5 commits into from
Mar 24, 2021

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Mar 23, 2021

Backport of #28326

See that PR for details.

Notes: Fix service worker not working with custom protocol.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 23, 2021
@trop trop bot requested a review from zcbenz March 23, 2021 15:17
@trop trop bot mentioned this pull request Mar 23, 2021
Merged
5 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 23, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 23, 2021
@zcbenz zcbenz merged commit 32d3e82 into 13-x-y Mar 24, 2021
@release-clerk
Copy link

release-clerk bot commented Mar 24, 2021

Release Notes Persisted

Fix service worker not working with custom protocol.

@trop trop bot deleted the trop/13-x-y-bp-fix-make-sure-service-worker-scheme-is-registered-with-allowserviceworkers-1616512642092 branch March 24, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zcbenz