Skip to content

fix: self.module.paths not working in web workers #29955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 2 commits into from
Jul 4, 2021
Merged

fix: self.module.paths not working in web workers #29955

zcbenz merged 2 commits into from
Jul 4, 2021

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Jun 30, 2021 •
edited
Loading

Description of Change

Closes #24735.

Fixes an issue where self.module.paths didn't work in a web worker context. Fixed with the same logic as is present in renderer/init.ts.

Checklist

Release Notes

Notes: Fixed an issue where self.module.paths wouldn't work in Workers.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/12-x-y labels Jun 30, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 30, 2021
@codebytere codebytere changed the title fix: global.module.paths in workers fix: self.module.paths in web workers Jun 30, 2021
@codebytere codebytere changed the title fix: self.module.paths in web workers fix: self.module.paths not working in web workers Jun 30, 2021
jkleinsc
jkleinsc requested changes Jun 30, 2021
View reviewed changes
@codebytere codebytere requested a review from jkleinsc June 30, 2021 15:52
@codebytere codebytere force-pushed the fix-self-module-paths branch from bb57b27 to 2bd8d54 Compare June 30, 2021 15:52
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 1, 2021
@zcbenz zcbenz merged commit af99112 into main Jul 4, 2021
@zcbenz zcbenz deleted the fix-self-module-paths branch July 4, 2021 23:48
@release-clerk
Copy link

release-clerk bot commented Jul 4, 2021

Release Notes Persisted

Fixed an issue where self.module.paths wouldn't work in Workers.

This was referenced Jul 4, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 4, 2021

I have automatically backported this PR to "12-x-y", please check out #30012

@trop
Copy link
Contributor

trop bot commented Jul 4, 2021

I have automatically backported this PR to "13-x-y", please check out #30013

@trop
Copy link
Contributor

trop bot commented Jul 4, 2021

I have automatically backported this PR to "14-x-y", please check out #30014

@lgrahl
Copy link

lgrahl commented Jul 5, 2021

Thanks to you three. 🙂

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@codebytere @BlackHole1
fix: self.module.paths not working in web workers (electron#29955)
c5f1a27 
* fix: global.module.paths in workers

* spec: add a regression test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

+2 more reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

self.module.paths is not set in Worker when loading via loadURL

6 participants

@codebytere @lgrahl @nornagon @jkleinsc @zcbenz