Skip to content

fix: webview should maximize on requestFullscreen #29987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 2 commits into from
Jul 5, 2021
Merged

fix: webview should maximize on requestFullscreen #29987

jkleinsc merged 2 commits into from
Jul 5, 2021

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Jul 2, 2021

Backport of #29952

See that PR for details.

Notes: Fix requestFullscreen inside webview does not make the element take fullscreen.

@trop trop bot requested a review from a team as a code owner July 2, 2021 00:56
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 2, 2021
@trop trop bot requested a review from zcbenz July 2, 2021 00:56
@trop trop bot mentioned this pull request Jul 2, 2021
Merged
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 2, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 2, 2021
@jkleinsc jkleinsc merged commit fc75bf0 into 13-x-y Jul 5, 2021
@jkleinsc jkleinsc deleted the trop/13-x-y-bp-fix-webview-should-maximize-on-requestfullscreen-1625187404305 branch July 5, 2021 18:36
@release-clerk
Copy link

release-clerk bot commented Jul 5, 2021

Release Notes Persisted

Fix requestFullscreen inside webview does not make the element take fullscreen.

@ryankashi ryankashi mentioned this pull request Aug 12, 2021
Closed
3 tasks
@ryankashi ryankashi mentioned this pull request Aug 30, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@miniak miniak miniak approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees

No one assigned

Labels

13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkleinsc @miniak @zcbenz