fix: pdf viewer permissions #29210
Merged
fix: pdf viewer permissions #29210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
May 19, 2021
codebytere
previously approved these changes
May 19, 2021
codebytere
reviewed
May 19, 2021
Member
codebytere
left a comment
There was a problem hiding this comment.
Looks like
chrome extensions lists loaded extensions in getAllExtensions
is failing across platforms 🤔
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "13-x-y", please check out #29252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #29191. The chromium roll #28462 included a change to shell/browser/extensions/electron_extension_system.cc to address https://chromium-review.googlesource.com/c/chromium/src/+/2771320, but the wrong
extensions::mojom::ManifestLocationwas used which caused a permissioning error which prevented the PDF viewer from displaying. This PR updates shell/browser/extensions/electron_extension_system.cc to use the properextensions::mojom::ManifestLocation.Checklist
npm testpassesRelease Notes
Notes: Fixed permissions issue that was preventing the PDF viewer from displaying.