Skip to content

fix: window bounds not scaled from screen coordinates #29227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 1 commit into from
May 19, 2021
Merged

fix: window bounds not scaled from screen coordinates #29227

zcbenz merged 1 commit into from
May 19, 2021

Conversation

@trop
Copy link
Contributor

@trop trop bot commented May 19, 2021

Backport of #29162

See that PR for details.

Notes: Fixed will-resize and will-move events not scaling the emitted newBounds rectangle to the appropriate Windows display scale factor.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 19, 2021
@trop trop bot mentioned this pull request May 19, 2021
Merged
4 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 19, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 19, 2021
@zcbenz zcbenz merged commit 75b4db4 into 13-x-y May 19, 2021
@release-clerk
Copy link

release-clerk bot commented May 19, 2021

Release Notes Persisted

Fixed will-resize and will-move events not scaling the emitted newBounds rectangle to the appropriate Windows display scale factor.

@trop trop bot deleted the trop/13-x-y-bp-fix-window-bounds-not-scaled-from-screen-coordinates-1621388146145 branch May 19, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcbenz @samuelmaddock