fix: mouse doesn't work on frameless browserwindows #30447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
zcbenz
approved these changes
Aug 9, 2021
MarshallOfSound
approved these changes
Aug 9, 2021
|
Release Notes Persisted
|
This was referenced Aug 10, 2021
Contributor
|
I have automatically backported this PR to "14-x-y", please check out #30459 |
Contributor
|
I have automatically backported this PR to "15-x-y", please check out #30460 |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #30402. This the issue that @electron/wg-releases marked as a stable blocker last week.
This bug is from the "CanResize has been de-virtualized" refactor in #29256
One-sentence summary: In order for CanResize() to return the right value here, we need to call SetCanResize() first.
Checklist
npm testpassesRelease Notes
Notes: Fix beta-only bug that caused mouse clicks to not be processed in frameless windows.