Skip to content

fix: generate valid config.gypi #31442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 1 commit into from
Oct 19, 2021
Merged

fix: generate valid config.gypi #31442

zcbenz merged 1 commit into from
Oct 19, 2021
+159 −53

Conversation

@zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Oct 15, 2021

Backport of #31404.

Notes: Generate valid config.gypi file in Node.js headers.

@zcbenz zcbenz requested a review from a team as a code owner October 15, 2021 00:33
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 15, 2021
@trop trop bot mentioned this pull request Oct 15, 2021
Merged
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 15, 2021
@zcbenz zcbenz force-pushed the valid-config-gypi-15 branch from c6f48b5 to 1b35604 Compare October 15, 2021 04:11
@zcbenz
Copy link
Contributor Author

zcbenz commented Oct 15, 2021

I also backported a Node.js patch to fix the build error on Windows CI.

@ckerr
Copy link
Member

ckerr commented Oct 18, 2021

win-ia32-testing CI failure looks unrealated:

Uploading artifact pdb.zip (707,671,409 bytes)...1%
Uploading artifact pdb.zip (707,671,409 bytes)...10%
Uploading artifact pdb.zip (707,671,409 bytes)...20%
Uploading artifact pdb.zip (707,671,409 bytes)...30%
Uploading artifact pdb.zip (707,671,409 bytes)...40%
Uploading artifact pdb.zip (707,671,409 bytes)...50%
Uploading artifact pdb.zip (707,671,409 bytes)...60%Error uploading artifact the storage: One or more errors occurred.
Sorry, we tried running command for 3 times and all attempts were unsuccessful!
Command exited with code 2

@zcbenz zcbenz merged commit ad67a27 into 15-x-y Oct 19, 2021
@zcbenz zcbenz deleted the valid-config-gypi-15 branch October 19, 2021 00:39
@release-clerk
Copy link

release-clerk bot commented Oct 19, 2021

Release Notes Persisted

Generate valid config.gypi file in Node.js headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees

No one assigned

Labels

15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zcbenz @ckerr @jkleinsc