-
Notifications
You must be signed in to change notification settings - Fork 16.8k
fix: clipboard.read() crash with custom types #31566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The change was made to match the behavior of I didn't realize |
|
@deepak1556 ah, so I should move the logic into |
|
Yup that would be the correct move. Thanks for making the change! |
2a3ba6a to
6711dfc
Compare
|
@deepak1556 done, thanks! |
|
Failure not germane. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "15-x-y", please check out #31591 |
|
I have automatically backported this PR to "16-x-y", please check out #31592 |
Description of Change
Closes #31556.
Fixes an issue where
clipboard.read()would cause crashes with custom clipboard formats as a result of 2798d15, which was itself added to compensate for CL:3039323. Upon further reading of the CL, it's not clear to me that we need to restrict format types to those returned fromExtractCustomPlatformNames, since that is for example empty on macOS and seems to be addressing something other than what we do inclipboard.read(). This caused a DCHECK:Stacktrace
since the list is, as mentioned above, empty in our case.
cc @deepak1556 in case i am somehow missing something about the change in the CL.
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where
clipboard.read()could cause crashes with custom clipboard formats.