Skip to content

fix: BrowserView setBackgroundColor() #31746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 1 commit into from
Nov 9, 2021
Merged

fix: BrowserView setBackgroundColor() #31746

jkleinsc merged 1 commit into from
Nov 9, 2021

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Nov 8, 2021 •
edited
Loading

Description of Change

Closes #31742.

Applies fix from #30777 to BrowserViews. Also updates #31722 to include BrowserViews.

Tested with https://gist.github.com/kevinlinv/2de60478ffec6a2f18f1ec0fc6f5add9

Checklist

Release Notes

Notes: Fix BrowserView.setBackgroundColor() not working correctly.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 8, 2021
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Nov 8, 2021
@codebytere codebytere force-pushed the fix-bv-backgroundcolor branch from c8a169f to 49297ea Compare November 8, 2021 15:23
@codebytere codebytere marked this pull request as draft November 8, 2021 22:36
@codebytere codebytere force-pushed the fix-bv-backgroundcolor branch from 49297ea to 2f5f4ae Compare November 9, 2021 08:37
@codebytere codebytere marked this pull request as ready for review November 9, 2021 08:40
@codebytere codebytere requested a review from miniak November 9, 2021 08:44
@codebytere codebytere force-pushed the fix-bv-backgroundcolor branch from 2f5f4ae to 0a764c2 Compare November 9, 2021 08:45
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 9, 2021
@jkleinsc jkleinsc merged commit b40f3d4 into main Nov 9, 2021
@jkleinsc jkleinsc deleted the fix-bv-backgroundcolor branch November 9, 2021 16:36
@release-clerk
Copy link

release-clerk bot commented Nov 9, 2021

Release Notes Persisted

Fix BrowserView.setBackgroundColor() not working correctly.

@trop
Copy link
Contributor

trop bot commented Nov 9, 2021

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/17-x-y label Nov 9, 2021
@trop
Copy link
Contributor

trop bot commented Nov 9, 2021

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Nov 9, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Nov 9, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Nov 9, 2021

I have automatically backported this PR to "16-x-y", please check out #31772

@codebytere codebytere mentioned this pull request Nov 15, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Nov 15, 2021

@codebytere has manually backported this PR to "15-x-y", please check out #31844

@codebytere codebytere mentioned this pull request Nov 15, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Nov 15, 2021

@codebytere has manually backported this PR to "14-x-y", please check out #31845

@codebytere codebytere mentioned this pull request Nov 16, 2021
Merged
3 tasks
t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@codebytere @t57ser
fix: BrowserView setBackgroundColor() (electron#31746)
2546d58
@commit-lint commit-lint bot mentioned this pull request Feb 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@samuelmaddock samuelmaddock Awaiting requested review from samuelmaddock

@miniak miniak Awaiting requested review from miniak

Assignees

No one assigned

Labels

semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: BrowserView.setBackgroundColor is not applied to the contents

3 participants

@codebytere @jkleinsc