Skip to content

fix: proper localization when using GtkFileChooserNative #31066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 2 commits into from
Sep 23, 2021
Merged

fix: proper localization when using GtkFileChooserNative #31066

zcbenz merged 2 commits into from
Sep 23, 2021

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Sep 22, 2021

Backport of #30888

See that PR for details.

Notes: Fixed an issue where button labels in file choosers were improperly localized on Linux.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 22, 2021
@trop trop bot requested a review from codebytere September 22, 2021 18:15
@trop trop bot mentioned this pull request Sep 22, 2021
Merged
3 tasks
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 22, 2021
@zcbenz zcbenz merged commit ee23788 into 15-x-y Sep 23, 2021
@zcbenz zcbenz deleted the trop/15-x-y-bp-fix-proper-localization-when-using-gtkfilechoosernative-1632334485423 branch September 23, 2021 07:35
@release-clerk
Copy link

release-clerk bot commented Sep 23, 2021

Release Notes Persisted

Fixed an issue where button labels in file choosers were improperly localized on Linux.

@WALLOUD
Copy link

WALLOUD commented Oct 4, 2021

Hellowave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere Awaiting requested review from codebytere

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WALLOUD @zcbenz @codebytere