Skip to content

fix: draggable regions in BrowserViews are independent #31200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 1 commit into from
Sep 30, 2021
Merged

fix: draggable regions in BrowserViews are independent #31200

jkleinsc merged 1 commit into from
Sep 30, 2021

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Sep 30, 2021

Backport of #31085

See that PR for details.

Notes: Fixed an issue where changes to draggable regions in a BrowserWindow incorrectly affected those in an attached BrowserView.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 30, 2021
@trop trop bot requested a review from codebytere September 30, 2021 09:41
@trop trop bot mentioned this pull request Sep 30, 2021
Merged
3 tasks
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Sep 30, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 30, 2021
@jkleinsc
Copy link
Member

jkleinsc commented Sep 30, 2021

Merging as CI failure is unrelated to PR change.

@jkleinsc jkleinsc merged commit 6230d95 into 14-x-y Sep 30, 2021
@jkleinsc jkleinsc deleted the trop/14-x-y-bp-fix-draggable-regions-in-browserview-s-are-independent-1632994892547 branch September 30, 2021 15:02
@release-clerk
Copy link

release-clerk bot commented Sep 30, 2021

Release Notes Persisted

Fixed an issue where changes to draggable regions in a BrowserWindow incorrectly affected those in an attached BrowserView.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees

No one assigned

Labels

14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkleinsc @codebytere