Skip to content

fix: check for maximized window before unmaximizing #32438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 1 commit into from
Jan 17, 2022
Merged

fix: check for maximized window before unmaximizing #32438

zcbenz merged 1 commit into from
Jan 17, 2022

Conversation

@dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Jan 12, 2022 •
edited
Loading

Description of Change

Fixes #32350.

Test is currently disabled on Linux until #28699 is fixed.

cc @ckerr

Checklist

Release Notes

Notes: Fixed minimized BrowserWindow being restored by BrowserWindow.unmaximize()

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 12, 2022
codebytere
codebytere previously approved these changes Jan 12, 2022
View reviewed changes
@codebytere codebytere dismissed their stale review January 12, 2022 16:57

meant to comment

codebytere
codebytere reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing the first test you added:

BrowserWindow module BrowserWindow.unmaximize() should not restore a minimized window - should not restore a minimized window

@dsanders11
Copy link
Member Author

dsanders11 commented Jan 12, 2022

@codebytere, yep, just saw that. I'll boot my Linux machine and see what's going on there, I only tested on Windows.

@dsanders11
Copy link
Member Author

dsanders11 commented Jan 12, 2022

Disabled the failing test for Linux. @codebytere offered to look into #28699, the test can be enabled on Linux again once that's fixed.

I put in some arbitrary waits to hopefully keep the test honest. Testing that something doesn't occur is always a bit tricky. Suggestions welcome if anyone has a better approach.

@codebytere codebytere mentioned this pull request Jan 12, 2022
Merged
3 tasks
@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/14-x-y labels Jan 13, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 13, 2022
@zcbenz zcbenz merged commit 0c75b3b into electron:main Jan 17, 2022
@release-clerk
Copy link

release-clerk bot commented Jan 17, 2022

Release Notes Persisted

Fixed minimized BrowserWindow being restored by BrowserWindow.unmaximize()

This was referenced Jan 17, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jan 17, 2022

I have automatically backported this PR to "14-x-y", please check out #32493

@trop
Copy link
Contributor

trop bot commented Jan 17, 2022

I have automatically backported this PR to "15-x-y", please check out #32494

@trop trop bot removed the target/14-x-y label Jan 17, 2022
@trop trop bot mentioned this pull request Jan 17, 2022
Merged
@trop trop bot mentioned this pull request Jan 17, 2022
Merged
@trop trop bot removed the target/15-x-y label Jan 17, 2022
@trop
Copy link
Contributor

trop bot commented Jan 17, 2022

I have automatically backported this PR to "16-x-y", please check out #32495

@trop
Copy link
Contributor

trop bot commented Jan 17, 2022

I have automatically backported this PR to "17-x-y", please check out #32496

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@dsanders11 @t57ser
fix: check for maximized window before unmaximizings (electron#32438)
3af57fe
@dsanders11 dsanders11 deleted the fix-32350 branch March 14, 2022 02:23
@commit-lint commit-lint bot mentioned this pull request Mar 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: BrowserWindow.unmaximize Will Restore Minimized Window

3 participants

@dsanders11 @zcbenz @codebytere