Skip to content

fix: corrupted title of alert dialog #32470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 1 commit into from
Jan 17, 2022
Merged

fix: corrupted title of alert dialog #32470

zcbenz merged 1 commit into from
Jan 17, 2022

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Jan 13, 2022

Backport of #32434

See that PR for details.

Notes: Fix an issue that the alert() dialog title is corrupted.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 13, 2022
@trop trop bot mentioned this pull request Jan 13, 2022
Merged
2 tasks
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 13, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 13, 2022
@zcbenz zcbenz merged commit de8623d into 16-x-y Jan 17, 2022
@zcbenz zcbenz deleted the trop/16-x-y-bp-fix-corrupted-title-of-alert-dialog-1642109062934 branch January 17, 2022 07:31
@release-clerk
Copy link

release-clerk bot commented Jan 17, 2022

Release Notes Persisted

Fix an issue that the alert() dialog title is corrupted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcbenz @babatakao