Skip to content

fix: window.open not overriding parent's webPreferences #32107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 2 commits into from
Dec 7, 2021
Merged

fix: window.open not overriding parent's webPreferences #32107

zcbenz merged 2 commits into from
Dec 7, 2021

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Dec 6, 2021

Backport of #32057

See that PR for details.

Notes: Fix window.open not overriding parent's webPreferences.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Dec 6, 2021
@trop trop bot requested a review from zcbenz December 6, 2021 03:55
@trop trop bot mentioned this pull request Dec 6, 2021
Merged
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Dec 6, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Dec 6, 2021
@zcbenz zcbenz merged commit d7a59f4 into 17-x-y Dec 7, 2021
@zcbenz zcbenz deleted the trop/17-x-y-bp-fix-window-open-not-overriding-parent-s-webpreferences-1638762898154 branch December 7, 2021 00:47
@release-clerk
Copy link

release-clerk bot commented Dec 7, 2021

Release Notes Persisted

Fix window.open not overriding parent's webPreferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zcbenz