Skip to content

fix: will-attach-webview handler modifying params.instanceId does not break <webview> #32386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 1 commit into from
Jan 12, 2022
Merged

fix: will-attach-webview handler modifying params.instanceId does not break <webview> #32386

zcbenz merged 1 commit into from
Jan 12, 2022

Conversation

@miniak
Copy link
Contributor

@miniak miniak commented Jan 7, 2022 •
edited
Loading

Description of Change

Don't break when internal undocumented params.instanceId is modified by application code.
Keep passing it to will-attach-webview in case an app reads the value.
Also remove unused userAgentOverride param.

Checklist

Release Notes

Notes: The <webview> implementation was made more robust, it no longer breaks when will-attach-webview handler modifies the internal params.instanceId.

@miniak miniak requested a review from a team as a code owner January 7, 2022 23:41
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 7, 2022
@miniak miniak self-assigned this Jan 7, 2022
@miniak miniak force-pushed the miniak/more-robust-will-attach-webview branch from a5040cc to 150ca6b Compare January 7, 2022 23:43
@miniak miniak added the semver/patch backwards-compatible bug fixes label Jan 7, 2022
@miniak miniak force-pushed the miniak/more-robust-will-attach-webview branch 3 times, most recently from b783197 to 201d30a Compare January 8, 2022 00:03
@miniak miniak force-pushed the miniak/more-robust-will-attach-webview branch from 201d30a to 07fa484 Compare January 8, 2022 00:10
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 8, 2022
@zcbenz zcbenz merged commit 99ee1fc into main Jan 12, 2022
@zcbenz zcbenz deleted the miniak/more-robust-will-attach-webview branch January 12, 2022 07:41
@release-clerk
Copy link

release-clerk bot commented Jan 12, 2022

Release Notes Persisted

The &lt;webview&gt; implementation was made more robust, it no longer breaks when will-attach-webview handler modifies the internal params.instanceId.

@trop
Copy link
Contributor

trop bot commented Jan 12, 2022

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/14-x-y label Jan 12, 2022
@trop trop bot mentioned this pull request Jan 12, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jan 12, 2022

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/15-x-y label Jan 12, 2022
@trop trop bot mentioned this pull request Jan 12, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jan 12, 2022

I have automatically backported this PR to "16-x-y", please check out #32429

@trop
Copy link
Contributor

trop bot commented Jan 12, 2022

I have automatically backported this PR to "17-x-y", please check out #32430

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@miniak @t57ser
fix: will-attach-webview handler modifying params.instanceId does not…
2fab4ee 
… break <webview> (electron#32386)
miniak added a commit that referenced this pull request Feb 10, 2022
@miniak
fix: will-attach-webview handler modifying params.instanceId does not…
71b1c03 
… break <webview> (#32386)
@miniak miniak mentioned this pull request Feb 10, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Feb 10, 2022

@miniak has manually backported this PR to "15-x-y", please check out #32855

deepak1556 pushed a commit that referenced this pull request Feb 14, 2022
@miniak
fix: will-attach-webview handler modifying params.instanceId does not…
fed01fb 
… break <webview> (#32386) (#32855)
@commit-lint commit-lint bot mentioned this pull request Mar 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@ppontes ppontes ppontes approved these changes

+2 more reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miniak miniak

Labels

semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miniak @ckerr @nornagon @zcbenz @ppontes