Skip to content

Conversation

@ppontes
Copy link
Member

@ppontes ppontes commented Apr 8, 2022

usb: Fix OOB access with non-sequential interfaces

When accessing a usb device with non-sequential interface number or
alternative setting value, it might end up using index out of the
internal array allocated size. It is caused by using incorrect
parameters (i.e interface_number and alternate_setting) into the
callback which expects taking interface_index and alternate_index. Fix
it by passing the correct parameters which are already available in the
function to the callback.

Bug: 1286816
Change-Id: I6b3533f944f94e94e63959b99718858e089449da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3384715
Reviewed-by: Reilly Grant reillyg@chromium.org
Commit-Queue: Jack Hsieh chengweih@chromium.org
Cr-Commit-Position: refs/heads/main@{#961679}

Notes: Backported fix for chromium:1286816.

@ppontes ppontes requested review from a team as code owners April 8, 2022 15:46
@ppontes ppontes added 17-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Apr 8, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Apr 8, 2022
@zcbenz zcbenz merged commit 39ff874 into 17-x-y Apr 14, 2022
@zcbenz zcbenz deleted the cherry-pick/17-x-y/chromium/a1dc371d6680 branch April 14, 2022 10:17
@release-clerk
Copy link

release-clerk bot commented Apr 14, 2022

Release Notes Persisted

Backported fix for chromium:1286816.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

17-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants