Skip to content

fix: prevent UAF crash in setCertificateVerifyProc #33255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 2 commits into from
Apr 6, 2022
Merged

fix: prevent UAF crash in setCertificateVerifyProc #33255

jkleinsc merged 2 commits into from
Apr 6, 2022

Conversation

@nornagon
Copy link
Contributor

@nornagon nornagon commented Mar 11, 2022 •
edited
Loading

Backport of #33204

Notes: Fixed a network service crash that could occur when using setCertificateVerifyProc.

@nornagon nornagon requested review from a team as code owners March 11, 2022 19:44
@nornagon nornagon added the semver/patch backwards-compatible bug fixes label Mar 11, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 11, 2022
@trop trop bot removed the semver/patch backwards-compatible bug fixes label Mar 11, 2022
@trop trop bot mentioned this pull request Mar 11, 2022
Merged
5 tasks
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 11, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 11, 2022
jkleinsc
jkleinsc previously requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch fails to apply

@nornagon nornagon requested a review from jkleinsc April 4, 2022 23:53
@jkleinsc jkleinsc merged commit 0dd20a2 into 16-x-y Apr 6, 2022
@jkleinsc jkleinsc deleted the backport/16-x-y/fix-setcertverifyproc-cancellation branch April 6, 2022 18:21
@release-clerk
Copy link

release-clerk bot commented Apr 6, 2022

Release Notes Persisted

Fixed a network service crash that could occur when using setCertificateVerifyProc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees

No one assigned

Labels

16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nornagon @jkleinsc