feat: add support for Web Bluetooth pin pairing #35416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
reviewed
Aug 25, 2022
3 tasks
dc673b9 to
ced73e4
Compare
nornagon
reviewed
Aug 26, 2022
61e9427 to
f0b9d19
Compare
ckerr
reviewed
Sep 20, 2022
erickzhao
reviewed
Sep 20, 2022
ckerr
reviewed
Sep 21, 2022
Member
ckerr
left a comment
There was a problem hiding this comment.
Archaeologist is showing some changes that seem unrelated to the PR.
I think this will go away once the PR is updated to be in sync with main but thought I'd point it out in case it's an actual issue
ckerr
reviewed
Sep 21, 2022
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "19-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "20-x-y" cleanly; |
Contributor
|
I have automatically backported this PR to "21-x-y", please check out #35818 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* feat: add bluetooth pairing handler * Update docs/api/session.md Co-authored-by: Charles Kerr <charles@charleskerr.com> * Update docs/api/session.md Co-authored-by: Charles Kerr <charles@charleskerr.com> * docs: update based on review * Apply suggestions from code review Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Charles Kerr <charles@charleskerr.com> * chore: update docs per review * chore: cleanup callback per review Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Erick Zhao <erick@hotmail.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
https://chromium-review.googlesource.com/c/chromium/src/+/2841104 added support for providing a pin for bluetooth devices on Windows and Linux when required but we simply stubbed out this functionality on the chromium roll (#31317). This PR adds a new event
bluetooth-pair-promptto Session to allow developers to handle the request for a pin when pairing a bluetooth device.Resolves #33111
Checklist
npm testpassesRelease Notes
Notes: Added support for Web Bluetooth pin pairing on Linux and Windows