fix: window.open popups are always resizable
#47540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fca3be to
1363801
Compare
clavin
approved these changes
Jun 26, 2025
1363801 to
4c043d7
Compare
samuelmaddock
approved these changes
Jun 30, 2025
Closes #43591. Per current WHATWG spec, the `window.open` API should always create a resizable popup window. This change updates the `parseFeaturesString` function to ensure that windows opened with `window.open` are always resizable, regardless of the `resizable` feature string.
4c043d7 to
f9210f2
Compare
|
Release Notes Persisted
|
codebytere
added a commit
that referenced
this pull request
Jul 11, 2025
fix: window.open popups are always resizable Closes #43591. Per current WHATWG spec, the `window.open` API should always create a resizable popup window. This change updates the `parseFeaturesString` function to ensure that windows opened with `window.open` are always resizable, regardless of the `resizable` feature string.
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
fix: window.open popups are always resizable Closes electron#43591. Per current WHATWG spec, the `window.open` API should always create a resizable popup window. This change updates the `parseFeaturesString` function to ensure that windows opened with `window.open` are always resizable, regardless of the `resizable` feature string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #43591.
Per current WHATWG spec, the
window.openAPI should always create a resizable popup window. This change updates theparseFeaturesStringfunction to ensure that windows opened withwindow.openare always resizable, regardless of theresizablefeature string.Checklist
npm testpassesRelease Notes
Notes: Fixed a spec compliance issue with
window.openwhere it should always create a resizable popup window but did not.