Skip to content

Conversation

@reitowo
Copy link
Member

@reitowo reitowo commented Sep 5, 2025

Description of Change

Add support to request RGBAF16 scRGB HDR when OSR.

Upstream changes merged: https://chromium-review.googlesource.com/c/chromium/src/+/6612522

Release Notes

Notes: Added RGBAF16 output format with scRGB HDR color space support to Offscreen Rendering.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 5, 2025
@reitowo reitowo changed the title feat: offscreen rendering support rgbaf16 feat: offscreen rendering support rgbaf16 hdr output format. Sep 5, 2025
@reitowo
Copy link
Member Author

reitowo commented Sep 5, 2025

The test is missing and it will be added when sharedTexture PR lands. The test about HDR format will be added there (seperately). Tested locally to be working.

image

@reitowo reitowo added semver/minor backwards-compatible functionality no-backport labels Sep 5, 2025
@reitowo reitowo added target/39-x-y PR should also be added to the "39-x-y" branch. and removed no-backport labels Sep 8, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 12, 2025
@reitowo
Copy link
Member Author

reitowo commented Sep 25, 2025

@jkleinsc Good to see retry works! 👍🏻👍🏻 Mega work!

https://github.com/electron/electron/actions/runs/18007138608/job/51232921251#step:21:2822

Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit 9e46efb into electron:main Oct 9, 2025
59 checks passed
@release-clerk
Copy link

release-clerk bot commented Oct 9, 2025

Release Notes Persisted

Added RGBAF16 output format with scRGB HDR color space support to Offscreen Rendering.

trop bot added a commit that referenced this pull request Oct 9, 2025
* feat: offscreen rendering support rgbaf16

* docs: update doc

* docs: update doc.

Co-authored-by: reito <reito@chromium.org>
@trop
Copy link
Contributor

trop bot commented Oct 9, 2025

I have automatically backported this PR to "39-x-y", please check out #48504

@trop trop bot added in-flight/39-x-y and removed target/39-x-y PR should also be added to the "39-x-y" branch. labels Oct 9, 2025
codebytere pushed a commit that referenced this pull request Oct 16, 2025
feat: offscreen rendering support rgbaf16 hdr output format. (#48265)

* feat: offscreen rendering support rgbaf16

* docs: update doc

* docs: update doc.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: reito <reito@chromium.org>
@trop trop bot removed the in-flight/39-x-y label Oct 16, 2025
@trop trop bot added the merged/39-x-y PR was merged to the "39-x-y" branch. label Oct 16, 2025
TheCommieAxolotl pushed a commit to TheCommieAxolotl/electron that referenced this pull request Nov 2, 2025
…n#48265)

* feat: offscreen rendering support rgbaf16

* docs: update doc

* docs: update doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review/approved ✅ merged/39-x-y PR was merged to the "39-x-y" branch. semver/minor backwards-compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants