[WIP] Let In Syntax Initial Impl#578
Draft
oldwomanjosiah wants to merge 7 commits into
Draft
Conversation
oldwomanjosiah
commented
Sep 19, 2022
| ), | ||
| x @ Literal(..) => x, | ||
| LetIn(_, d, b) => { | ||
| todo!("Resolve Refs is unused, TODO(josiah)"); |
Contributor
Author
There was a problem hiding this comment.
It's unclear to me atm what should be done here. As far as I can tell the function is (transitively) unused, and could be removed, so it might not be a problem.
It might make the most sense to use the values from the let block to map the inner vars, but the variable defs haven't been evaluated yet here.
98140f9 to
98e6c43
Compare
Contributor
Author
|
@elkowar Just following up here to see if you have any feedback on the direction of this? Specifically if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is not intended to be final, but I had some time so I thought I would work on this. First pass ended up being easier than I was expecting.
trueandfalsewithin idents, so long as it is not the entire thing.Usage
Showcase
My current workspace indicator:
Where I have a script that outputs the following on workspace changes:
{ "1": { "dis": -1, "ex": false, "urg": false }, ... }And the let-in syntax to pull out the relevant information for each part
Diffs containing fuller example of usage
Additional Notes
I borrowed the testing macro from #577
Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/maindirectory has been adjusted to reflect my changes.cargo fmtto automatically format all code before committing